Make reader engine selection collective and fail cleanly. (release branch)#5101
Merged
eisenhauer merged 1 commit intoJun 23, 2026
Merged
Conversation
It probed the filesystem from every rank and, for a non-existent path, could pick BP3 and throw only on rank 0, hanging the others (ornladios#5098). Now the probe runs on rank 0 and the chosen engine (or a clear error) is broadcast, so a missing location fails collectively with a SetEngine hint instead of hanging. (cherry picked from commit acd9c0a) Backport adaptation: dropped the DAOS auto-detect branch (the DAOS engine and helper::IsDAOSDataset are not in release_212) and the master-only whatsnew section.
eisenhauer
requested review from
pnorbert and
vicentebolea
and removed request for
vicentebolea
pnorbert
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an adapted backport of master PR 5099. It differs mainly in that it doesn't refer to IsDAOSDataset (DAOS engine not present in release 2.12).